fix: stale mock metadata breaks automocking with isolate:false (fix #10145)#10541
Open
kade-robertson wants to merge 4 commits into
Open
fix: stale mock metadata breaks automocking with isolate:false (fix #10145)#10541kade-robertson wants to merge 4 commits into
kade-robertson wants to merge 4 commits into
Conversation
sheremet-va
requested changes
Jun 9, 2026
| mockedModule, | ||
| ) | ||
| if (currentMock !== mockedModule) { | ||
| const freshNode = await this.fetchModule(injectQuery(url, '_vitest_original')) |
Member
There was a problem hiding this comment.
If it's a manual or redirect mock, then this is not needed because it won't be used to autospy/automock
Author
There was a problem hiding this comment.
If I understand correctly I believe f394cb4 addresses this
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
isolate: falseis set and two test files mock the same module differently (one with a factory, one with automocking), the automock is silently skipped if the factory-mock file runs first. This happens becausefetchModulebakesmockedModule(withcode: '') into the module node'smeta, and withisolate: falsethis metadata persists across test files. When a later file registers an automock for the same module,cachedRequestwas using the stale manual mock from meta instead of the current automock from the registry.The fix adds an additional check after the early stale / self-import returns to see if
currentMockandmockedModulediffer, we re-fetch.A
resolve.aliasis required to trigger the bug.Resolves #10145
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.